Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CI to merge queues #3981

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Switch CI to merge queues #3981

merged 1 commit into from
Oct 22, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Oct 21, 2024 •
edited
Loading

This should be merged in cooperation with an infra admin.

This was referenced Oct 21, 2024
Merged
Closed
Closed
MarcoIeni
MarcoIeni approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@MarcoIeni MarcoIeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RalfJung
RalfJung reviewed Oct 21, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
RalfJung
RalfJung reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have one more comment nit that helps explain why we need the if: at all.

With that nit applied, feel free to land this and do the infra-side changes whenever it is convenient for you.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor Author

Kobzol commented Oct 22, 2024

Added the all caps part and your suggestion for the comment. Thanks for the review!

MarcoIeni
MarcoIeni approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@MarcoIeni MarcoIeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great description. We could copy it to other rust repos as well 👍

@MarcoIeni MarcoIeni added this pull request to the merge queue Oct 22, 2024
Merged via the queue into rust-lang:master with commit 0bf9284 Oct 22, 2024
6 checks passed
@Kobzol Kobzol deleted the ci-merge-queue branch October 22, 2024 11:10
@bors bors mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@MarcoIeni MarcoIeni MarcoIeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kobzol @RalfJung @MarcoIeni